I’ve spent last four days addressing the various issues with tests, arcanist, linters, and files all across the Sealcode stack. It involved a lot of changes and tests behind the curtain (in jdd, sealgen, sealious), as well as some significant changes to the sealious-playground itself, and apps based on it.
It was a deep dive! Here I’ll try to recount the changes that you should know about:
- Linting is now part of tests. This removes reliance on Arcanist for running the linter and will be much faster;
- Tests are now ran with Mocha instead of Vitest. So no more browser-based GUI and problems with “sharp wasn’t loaded”. The tests now may run slightly slower (it really depends on your CPU - for some this version might be faster), but are WAY more reliable
- I’ve harmonized the way files are represented all across the stack. No more
SealiousFile/FileDescription/file_iddillema. Now all files are represented by unpredictable string tokens. More on that later in a separate post. - I’ve fixed all the test errors that I could find. A big issue was that we were using the randomized page for tests, and it caused the tests to sometimes pass, and sometimes fail
@FilipI it was impossible for me to avoid making changes to the sreact page, although I tried to keep it to minimum. I will personally resolve any merge conflicts that are a result of that
