T2859 - "URL" JDD component argument type

Open-source projects JDD
23

fixed in both D1386 and D1387

1 Like
24

Added a comment in D1386

25

new diff D1386 uploaded, build failed, how can i check that, I dont have access to jenkins

i can see that, but it tells me nothing https://hub.sealcode.org/harbormaster/build/6125/

26

Iā€™ve re-run the test manually after restarting jenkins and it un-clogged :+1: Will do review soon

27

two tests are failing in sealious-playground:

/src/back/routes/todo.test.ts

AssertionError: Expected values to be strictly deep-equal:
+ actual - expected

  Comparison {
+   name: 'SyntaxError'
-   name: 'Error'
  }

- Expected
+ Received

- Object {
-   "name": "Error",
- }
+ [SyntaxError: Unexpected token 'o', "no access" is not valid JSON]

src/back/routes/logout.test.ts

doesn't crash

AssertionError: Expected values to be strictly deep-equal:
+ actual - expected

  Comparison {
+   name: 'SyntaxError'
-   name: 'Error'
  }

 - /src/back/routes/logout.test.ts:30:5

 - /src/back/test_utils/with-prod-app.ts:66:3

- Expected
+ Received

- Object {
-   "name": "Error",
- }
+ [SyntaxError: Unexpected token 'N', "Not Found" is not valid JSON]
28

Ah, sorry. Itā€™s a post-merge issue, my bad for not testing it.

Iā€™ve pushed a fixed version :+1:

1 Like
29

new diffs for cr: D1407, D1408

they includes the same changes as the previous one, but on a new branches. I moved the old changes to new ones cuz I couldnā€™t fix the old versions after merge conflicts.

30

In such cases you donā€™t have to create new diffs. You can just create a new branch in your repo, create a new set of changes, and update those diffs (using the regular arc diff --update workflow.

Please mark the two new diffs as Abandoned and update the old ones so itā€™s all neat and clean

31

D1387 and D1386 updated

1 Like
32

ready to land!

33

what if Iā€™m on the new branch and I canā€™t make patch

$ arc patch 1386
Branch name arcpatch-D1386 already exists; trying a new name.
Branch name arcpatch-D1386_1 already exists; trying a new name.
Branch name arcpatch-D1386_2 already exists; trying a new name.
Branch name arcpatch-D1386_3 already exists; trying a new name.
 Exception
34

See the troubleshooting section in āš” Arcanist - Phabricator CLI

35

Published to NPM as @sealcode/jdd@0.3.3 :+1:

1 Like